/test pull-kubernetes-unit

@deads2k - it seems those failures are not flakes. Can you please take a look?

@deads2k - it seems those failures are not flakes. Can you please take a look?

Looks like an incomplete federation stub of some kind. Maybe they can just do whatever they change in 1.8.

@deads2k - this is not failing on 1.7 branch and on other cherrypicks. This is related to this particular PR.

/retest

/test pull-kubernetes-unit

/lgtm

@kubernetes/sig-federation-bugs @nikhiljindal PTAL.
This fix is important for 1.7, and appears blocked by the failing unit test.

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@foxish - I'm pretty convinced that failing unit tests are related to this cl - I have seen this failure on any other PR to 1.7 branch and on this one I've seen them 5+ times

Sorry, I see that now. I was thrown off by @deads2k's comment. Investigating further.

Looks like these tests were deleted entirely in master in #47890.

@kubernetes/sig-federation-bugs @nikhiljindal PTAL.
This fix is important for 1.7, and appears blocked by the failing unit test.

Spent some time on this, and raised #50771 to still let those federated namespace unit tests run ok with the changes in this cherry-pick PR.

Looks like these tests were deleted entirely in master in #47890.

@foxish you are right, we have done away with these tests completely and no longer exist on master (thanks to @maruns efforts). In the tests which still exist on 1.7, the tests actually do not at all use the discovery functions, but there is no faked method which can bypass the checks introduced in this PR during initialising the controller. This cherry-pick should work if its put on top of the PR that I submitted.
cc @nikhiljindal .

/retest

/lgtm

@wojtek-t: you cannot LGTM your own PR.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxish, wojtek-t

Associated issue: 49495

The full list of commands accepted by this bot can be found here.

/retest

I'm not convinced that those flakes aren't real issues - those are to frequent comparing to other PRs.
Also it's pretty late and we really want to cut the release today.
So I'm declining to take this PR into 1.7.4 - we should try to let this in for 1.7.5 (we can consider another patch release next week if this is so important).

/test pull-kubernetes-e2e-gce-etcd3

They don't look related to the change though.

Different tests failing each time, which make me suspect it is indeed a flake. Retesting.
/test pull-kubernetes-e2e-gce-etcd3

@wojtek-t, removed do-not-merge. 1.7.4 is cut already as I understand. Targeting this for 1.7.5.

/test pull-kubernetes-e2e-gce-etcd3

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

/test all [submit-queue is verifying that this PR is safe to merge]

Automatic merge from submit-queue